Repository navigation
docs(dispatcher): remove stale legacy Identity absence note - #16380
Merged
agentydragon merged 1 commit intoNov 14, 2026
Merged
agentydragon merged 1 commit into
agentydragon merged 1 commit into
Conversation
agentydragon-agent
force-pushed
the
agentplane-dispatcher-doc-comments
branch
from
November 14, 2026 08:13
79a4419 to
8493764
Compare
agentydragon
enabled auto-merge (squash)
November 14, 2026 08:16
Contributor
Visual review for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the stale legacy-absence claim from
Session.identityfield 16. The protobuf field number and Identity fencing are unchanged.Per-line audit
dispatcher/README.md(around line 99): kept. Migration 18 does not delete a Session only because its ServiceAccount owner columns are NULL; it deletes rows withoutexecution_identity_nameor without caller attribution. The current Identity-run Session path can retain an exact execution Identity and attribution without a managed ServiceAccount. A same-named ServiceAccount does not inherit access to that Session.dispatcher/SPEC.md(around line 133): kept for the same live shape. Current Session creation records a complete execution Identity, while the ServiceAccount owner columns can remain NULL. Migration 18 retains rows with execution Identity and attribution even when those columns are NULL.session_dispatcher.protofield 16: rewritten. Migration 18 deletes rows with a missing execution Identity. CurrentCreateSessionrequires a complete Identity, Store creation rejects an incomplete Identity, andscanSessionrejects missing or incomplete stored Identity before the response projection. No current response can omit field 16 because of a pre-cutover row. The new comment makes no Sandbox, Sandbox UID, or single-environment requirement.I checked
agentplane/plans/session_environment_model.mdand theREFACTOR_COHERENCE_AUDITentry inagentplane/plans/task_dag.md. The selected central Session design allows zero or multiple environment attachments, and this change does not make an environment mandatory.Deliberate exclusions
The README and SPEC owner-column lines stay because that nullable ServiceAccount-owner shape is still possible for Identity-run Sessions. Notification Service
owner_namespace/owner_namecolumns are unrelated and untouched.Tests
No system test specifically covers these comments. Existing Dispatcher integration tests cover Identity-run Sessions and the Identity response projection. This is a comment-only change; no tests were run.
pre-commit run --files agentplane/runner_gateway/dispatcher/api/session/session_dispatcher.protopassed.Questions for Claude
GitHub reports auto-merge enabled on #16380 by the repository account. I tried to disable it with the authorized
agentydragon-agenttoken, but GitHub returnedFORBIDDENfordisablePullRequestAutoMerge. Please disable auto-merge manually so this PR remains for hand review and merge.